Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing compilation in Debug mode. #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing compilation in Debug mode. #65

wants to merge 1 commit into from

Conversation

pfankhauser
Copy link
Contributor

This fixes the unit quaternion check when building in Debug, however it breaks the unit test at

/home/peter/catkin_ws/src/curves/curves/test/CubicHermiteSE3CurveTest.cpp:261:

Couldn't figure out what goes wrong here, any ideas?

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@rdube
Copy link
Contributor

rdube commented Mar 28, 2017

@pfankhauser isn't Jenkins setup to verify PRs? I'll try on my machine.

@rdube
Copy link
Contributor

rdube commented Mar 28, 2017

@pfankhauser I get the same issue, with the rotational part failing. Which part of the modif did solve the building in debug? The new construction of the w1_dbeta1 ... objects or the construction of qDiff with normalization? Are you sure that both modifs are needed and maybe we can use this to isolate? Also which constructor of https://github.com/ethz-asl/kindr/blob/9a0d954636278e79b62e21a2ea4d7d664265f5be/include/kindr/rotations/RotationQuaternion.hpp#L55 is used? I could not find one taking a 3x1 eigen matrix.

@pfankhauser
Copy link
Contributor Author

@dbellicoso what's the state of this with your latest fixes?

@helenol
Copy link

helenol commented Aug 22, 2017

add to whitelist

@HannesSommer
Copy link

I've killed the curves_tests on ibex-trusty after it had consumed > 700 minutes of CPU time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gehrinch gehrinch Awaiting requested review from gehrinch

@rdube rdube Awaiting requested review from rdube

@gawela gawela Awaiting requested review from gawela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pfankhauser @ethzasl-jenkins @rdube @helenol @HannesSommer